Fix IIS LoaderOptimisation tests not testing anything #6209

andrewlock · 2024-10-28T13:48:25Z

Summary of changes

Fixes the "LoaderOptimization" IIS tests

Reason for change

While working on a separate issue, discovered that the LoaderOptimzation tests (in the msi_integration_tests stage aren't testing anything because the MSI isn't actually being installed 🤦

Implementation details

The "fix" is

dotnet_tracer_msi => DOTNET_TRACER_MSI in the docker compose build step
Add the msi to the .dockerignore so that it's actually added to the container 😬

Also took the chance to refactor this a little too (in preparation for a stacked PR)

Map the logs directory inside the container into build_data/logs
Rename the generic "IIS" name in the docker file/docker-compose to flag that it's explicitly for testing the LoaderOptimization behaviour
Added a check to the end of the smoke tests that makes sure we have some tracing logs. We could be more specific about this, run an agent inside the container etc, but this is better than nothing and is simple for now

Test coverage

Discovered this wasn't working in a separate PR, so as long as the tests pass (and the artifacts for the msi stage confirm we do have logs, then we should be good

Other details

Prerequiste for testing the behaviour in this PR

datadog-ddstaging · 2024-10-28T14:24:10Z

Datadog Report

Branch report: andrew/ci/fix-loader-optimisation-tests
Commit report: 5f1ebdf
Test service: dd-trace-dotnet

✅ 0 Failed, 367953 Passed, 2108 Skipped, 14h 14m 55.25s Total Time

andrewlock · 2024-10-28T14:32:40Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6209) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6209) - mean (1,116ms)  : 1093, 1140
     .   : milestone, 1116,
    master - mean (1,115ms)  : 1094, 1137
     .   : milestone, 1115,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6209) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6209) - mean (774ms)  : 757, 792
     .   : milestone, 774,
    master - mean (775ms)  : 757, 792
     .   : milestone, 775,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6209) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6209) - mean (732ms)  : 715, 748
     .   : milestone, 732,
    master - mean (731ms)  : 714, 748
     .   : milestone, 731,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6209) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 188, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6209) - mean (1,201ms)  : 1180, 1222
     .   : milestone, 1201,
    master - mean (1,198ms)  : 1176, 1220
     .   : milestone, 1198,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6209) - mean (276ms)  : 270, 282
     .   : milestone, 276,
    master - mean (277ms)  : 271, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6209) - mean (942ms)  : 927, 956
     .   : milestone, 942,
    master - mean (944ms)  : 924, 964
     .   : milestone, 944,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6209) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (265ms)  : 261, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6209) - mean (925ms)  : 904, 947
     .   : milestone, 925,
    master - mean (929ms)  : 907, 950
     .   : milestone, 929,

andrewlock · 2024-10-28T15:52:26Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6209) (11.217M)   : 0, 11217293
    master (11.115M)   : 0, 11115307
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6209) (7.458M)   : 0, 7458159
    master (7.335M)   : 0, 7334625
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.700M)   : 0, 7700429

    section Manual
    master (10.990M)   : 0, 10989510

    section Manual + Automatic
    This PR (6209) (6.889M)   : 0, 6889227
    master (6.780M)   : 0, 6780487

    section DD_TRACE_ENABLED=0
    master (10.305M)   : 0, 10305060

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6209) (9.511M)   : 0, 9511221
    master (9.774M)   : 0, 9773727
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6209) (6.622M)   : 0, 6622316
    master (6.463M)   : 0, 6462618

    section Trace stats
    master (6.907M)   : 0, 6906626

    section Manual
    master (9.697M)   : 0, 9697280

    section Manual + Automatic
    This PR (6209) (6.139M)   : 0, 6139077
    master (6.155M)   : 0, 6155472

    section DD_TRACE_ENABLED=0
    master (8.868M)   : 0, 8867528

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6209) (9.793M)   : 0, 9792860
    master (10.077M)   : 0, 10076675
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6209) (6.537M)   : 0, 6536652
    master (6.567M)   : 0, 6566975
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.314M)   : 0, 7314135

    section Manual
    master (10.073M)   : 0, 10073436

    section Manual + Automatic
    This PR (6209) (6.171M)   : 0, 6170879
    master (6.134M)   : 0, 6134127

    section DD_TRACE_ENABLED=0
    master (9.536M)   : 0, 9535909

andrewlock · 2024-10-28T22:10:36Z

Benchmarks Report for tracer 🐌

Benchmarks for #6209 compared to master:

1 benchmarks are faster, with geometric mean 1.202
1 benchmarks are slower, with geometric mean 1.189
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.5μs	42.6ns	307ns	0.0149	0.00745	0	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	9.83μs	51.5ns	258ns	0.0192	0.0096	0	5.61 KB
master	`StartStopWithChild`	net472	16.2μs	61.4ns	238ns	1.04	0.325	0.0974	6.06 KB
#6209	`StartStopWithChild`	net6.0	7.57μs	41.7ns	260ns	0.0179	0.00714	0	5.43 KB
#6209	`StartStopWithChild`	netcoreapp3.1	10μs	56.4ns	357ns	0.0197	0.00987	0	5.62 KB
#6209	`StartStopWithChild`	net472	16.2μs	49.5ns	185ns	1.02	0.298	0.0968	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	468μs	453ns	1.76μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	646μs	384ns	1.44μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	632ns	2.45μs	0.422	3.3 KB
#6209	`WriteAndFlushEnrichedTraces`	net6.0	476μs	263ns	1.02μs	0	2.7 KB
#6209	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	631μs	295ns	1.1μs	0	2.7 KB
#6209	`WriteAndFlushEnrichedTraces`	net472	841μs	422ns	1.64μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	202μs	1.18μs	10.8μs	0.194	18.45 KB
master	`SendRequest`	netcoreapp3.1	225μs	1.28μs	10.2μs	0.222	20.61 KB
master	`SendRequest`	net472	0.00142ns	0.000631ns	0.00244ns	0	0 b
#6209	`SendRequest`	net6.0	201μs	1.19μs	11.6μs	0.219	18.45 KB
#6209	`SendRequest`	netcoreapp3.1	224μs	1.3μs	11μs	0.258	20.61 KB
#6209	`SendRequest`	net472	0.000503ns	0.000277ns	0.000998ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	595μs	3.27μs	21.2μs	0.592	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	2.91μs	10.9μs	0.347	0	0	41.89 KB
master	`WriteAndFlushEnrichedTraces`	net472	899μs	4.15μs	16.1μs	8.48	2.23	0.446	53.33 KB
#6209	`WriteAndFlushEnrichedTraces`	net6.0	568μs	3.19μs	21.4μs	0.548	0	0	41.49 KB
#6209	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	677μs	3.4μs	16.3μs	0.331	0	0	41.75 KB
#6209	`WriteAndFlushEnrichedTraces`	net472	850μs	3.93μs	15.7μs	8.45	2.53	0.422	53.34 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.32μs	0.766ns	2.76ns	0.014	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.22ns	4.57ns	0.0133	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	1.82ns	7.04ns	0.156	987 B
#6209	`ExecuteNonQuery`	net6.0	1.2μs	1.15ns	4.29ns	0.0145	1.02 KB
#6209	`ExecuteNonQuery`	netcoreapp3.1	1.7μs	1.28ns	4.78ns	0.0135	1.02 KB
#6209	`ExecuteNonQuery`	net472	2.09μs	1.22ns	4.4ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.907ns	3.39ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.52μs	1.88ns	7.28ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.61μs	2.47ns	9.24ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.34μs	2.6ns	9.36ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	1.02ns	3.82ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.45μs	2.34ns	9.05ns	0.166	1.05 KB
#6209	`CallElasticsearch`	net6.0	1.22μs	1.47ns	5.49ns	0.0134	976 B
#6209	`CallElasticsearch`	netcoreapp3.1	1.52μs	1.69ns	6.32ns	0.013	976 B
#6209	`CallElasticsearch`	net472	2.53μs	1.14ns	4.25ns	0.158	995 B
#6209	`CallElasticsearchAsync`	net6.0	1.33μs	0.669ns	2.41ns	0.0134	952 B
#6209	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.771ns	2.67ns	0.014	1.02 KB
#6209	`CallElasticsearchAsync`	net472	2.58μs	0.984ns	3.68ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.33μs	0.549ns	2.05ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.628ns	2.43ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.8μs	1.78ns	6.9ns	0.145	915 B
#6209	`ExecuteAsync`	net6.0	1.23μs	0.637ns	2.29ns	0.0134	952 B
#6209	`ExecuteAsync`	netcoreapp3.1	1.59μs	0.836ns	3.13ns	0.0127	952 B
#6209	`ExecuteAsync`	net472	1.72μs	0.939ns	3.51ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.25μs	1.05ns	3.77ns	0.03	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.25μs	3.37ns	13.1ns	0.0356	2.76 KB
master	`SendAsync`	net472	7.8μs	4.87ns	18.2ns	0.496	3.15 KB
#6209	`SendAsync`	net6.0	4.15μs	2.01ns	7.8ns	0.0312	2.22 KB
#6209	`SendAsync`	netcoreapp3.1	5.11μs	2.63ns	10.2ns	0.0359	2.76 KB
#6209	`SendAsync`	net472	7.73μs	1.5ns	5.81ns	0.499	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.47μs	3.37ns	12.6ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.2μs	1.35ns	4.87ns	0.022	1.64 KB
master	`EnrichedLog`	net472	2.54μs	0.822ns	3.07ns	0.249	1.57 KB
#6209	`EnrichedLog`	net6.0	1.52μs	7.2ns	28.8ns	0.0229	1.64 KB
#6209	`EnrichedLog`	netcoreapp3.1	2.16μs	0.99ns	3.57ns	0.0217	1.64 KB
#6209	`EnrichedLog`	net472	2.46μs	0.774ns	2.9ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	130ns	505ns	0.06	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	123μs	127ns	475ns	0.0618	0	4.28 KB
master	`EnrichedLog`	net472	153μs	186ns	697ns	0.692	0.231	4.46 KB
#6209	`EnrichedLog`	net6.0	116μs	274ns	1.06μs	0.0576	0	4.28 KB
#6209	`EnrichedLog`	netcoreapp3.1	123μs	178ns	688ns	0.0607	0	4.28 KB
#6209	`EnrichedLog`	net472	151μs	75.1ns	281ns	0.673	0.224	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.19μs	1.03ns	3.87ns	0.0303	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.06μs	2.11ns	7.59ns	0.0286	2.2 KB
master	`EnrichedLog`	net472	4.75μs	2.42ns	9.37ns	0.319	2.02 KB
#6209	`EnrichedLog`	net6.0	2.98μs	0.96ns	3.59ns	0.0311	2.2 KB
#6209	`EnrichedLog`	netcoreapp3.1	4.28μs	1.2ns	4.47ns	0.0299	2.2 KB
#6209	`EnrichedLog`	net472	4.75μs	0.974ns	3.77ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.34μs	0.772ns	2.99ns	0.016	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.89ns	3.33ns	0.0159	1.14 KB
master	`SendReceive`	net472	2.13μs	0.993ns	3.85ns	0.183	1.16 KB
#6209	`SendReceive`	net6.0	1.37μs	0.847ns	3.17ns	0.0159	1.14 KB
#6209	`SendReceive`	netcoreapp3.1	1.73μs	0.927ns	3.59ns	0.0154	1.14 KB
#6209	`SendReceive`	net472	2.05μs	1.56ns	6.05ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.72μs	0.714ns	2.57ns	0.0219	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.9μs	3.06ns	11.8ns	0.0213	1.65 KB
master	`EnrichedLog`	net472	4.21μs	2.43ns	9.09ns	0.322	2.04 KB
#6209	`EnrichedLog`	net6.0	2.85μs	0.884ns	3.42ns	0.0229	1.6 KB
#6209	`EnrichedLog`	netcoreapp3.1	3.92μs	1.31ns	5.06ns	0.0215	1.65 KB
#6209	`EnrichedLog`	net472	4.45μs	2.93ns	11ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6209

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.189	402.47	478.72

Faster 🎉 in #6209

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.202	577.76	480.69

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	403ns	0.26ns	0.974ns	0.0081	576 B
master	`StartFinishSpan`	netcoreapp3.1	608ns	1.55ns	6.02ns	0.00768	576 B
master	`StartFinishSpan`	net472	748ns	0.756ns	2.93ns	0.0916	578 B
master	`StartFinishScope`	net6.0	578ns	0.161ns	0.582ns	0.00969	696 B
master	`StartFinishScope`	netcoreapp3.1	748ns	0.634ns	2.46ns	0.0094	696 B
master	`StartFinishScope`	net472	942ns	0.829ns	3.1ns	0.104	658 B
#6209	`StartFinishSpan`	net6.0	479ns	0.175ns	0.656ns	0.00817	576 B
#6209	`StartFinishSpan`	netcoreapp3.1	549ns	0.229ns	0.856ns	0.00771	576 B
#6209	`StartFinishSpan`	net472	672ns	0.304ns	1.14ns	0.0915	578 B
#6209	`StartFinishScope`	net6.0	480ns	0.21ns	0.815ns	0.00989	696 B
#6209	`StartFinishScope`	netcoreapp3.1	732ns	1.74ns	6.74ns	0.00924	696 B
#6209	`StartFinishScope`	net472	866ns	0.353ns	1.37ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	611ns	0.366ns	1.42ns	0.00976	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	931ns	0.893ns	3.46ns	0.00939	696 B
master	`RunOnMethodBegin`	net472	1.19μs	0.685ns	2.47ns	0.104	658 B
#6209	`RunOnMethodBegin`	net6.0	653ns	0.636ns	2.46ns	0.00984	696 B
#6209	`RunOnMethodBegin`	netcoreapp3.1	954ns	2.65ns	9.91ns	0.0094	696 B
#6209	`RunOnMethodBegin`	net472	1.19μs	0.24ns	0.928ns	0.104	658 B

Due to a mismatch in `args`, the tracer was never actually installed, which means this test hasn't been running Added check to make sure that we're recording tracer logs to be safe (we could test more, but gets more complex)

…seeing as it depends on services from there

andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Oct 28, 2024

andrewlock requested review from a team as code owners October 28, 2024 13:48

andrewlock changed the title ~~Fix LoaderOptimisation tests~~ Fix IIS LoaderOptimisation tests Oct 28, 2024

andrewlock changed the title ~~Fix IIS LoaderOptimisation tests~~ Fix IIS LoaderOptimisation tests not testing anything Oct 28, 2024

andrewlock force-pushed the andrew/ci/fix-loader-optimisation-tests branch from 7bf7733 to a98e2b3 Compare October 28, 2024 14:01

andrewlock force-pushed the andrew/ci/fix-loader-optimisation-tests branch 4 times, most recently from eb0bf49 to b00cec6 Compare October 28, 2024 17:25

lucaspimentel approved these changes Oct 28, 2024

View reviewed changes

andrewlock force-pushed the andrew/ci/fix-loader-optimisation-tests branch 2 times, most recently from 8521363 to 28b3711 Compare October 29, 2024 08:48

kevingosse approved these changes Oct 29, 2024

View reviewed changes

andrewlock added 3 commits October 29, 2024 10:30

Fix LoaderOptimisation tests

1f41fdf

Due to a mismatch in `args`, the tracer was never actually installed, which means this test hasn't been running Added check to make sure that we're recording tracer logs to be safe (we could test more, but gets more complex)

Try adding the test agent

29bac40

Move the LoaderOptimizationStartup step to a separate docker-compose …

5f1ebdf

…seeing as it depends on services from there

andrewlock force-pushed the andrew/ci/fix-loader-optimisation-tests branch from faebc6a to 5f1ebdf Compare October 29, 2024 10:31

andrewlock merged commit b7be50c into master Oct 29, 2024
72 of 75 checks passed

andrewlock deleted the andrew/ci/fix-loader-optimisation-tests branch October 29, 2024 12:46

github-actions bot added this to the vNext-v3 milestone Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix IIS LoaderOptimisation tests not testing anything #6209

Fix IIS LoaderOptimisation tests not testing anything #6209

andrewlock commented Oct 28, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 28, 2024 •

edited

Loading

andrewlock commented Oct 28, 2024 •

edited

Loading

andrewlock commented Oct 28, 2024 •

edited

Loading

andrewlock commented Oct 28, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6209

Faster 🎉 in #6209

Raw results

Raw results

Fix IIS LoaderOptimisation tests not testing anything #6209

Fix IIS LoaderOptimisation tests not testing anything #6209

Conversation

andrewlock commented Oct 28, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Oct 28, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 28, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 28, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Oct 28, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6209

Faster 🎉 in #6209

Raw results

Raw results

andrewlock commented Oct 28, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 28, 2024 •

edited

Loading

andrewlock commented Oct 28, 2024 •

edited

Loading

andrewlock commented Oct 28, 2024 •

edited

Loading